Add machine type in zone validator #5099

saara-tyagi27 · 2026-01-13T10:18:38Z

Summary

This PR introduces a new validator, test_machine_type_in_zone validator ensures Google Cloud machine type availability via the Compute Engine API prior to deployment. The logic automatically identifies and validates settings matching machine_type suffix against zone across all blueprint modules.

Key Features

Automatic Discovery: The validator automatically identifies and validates all module settings matching the machine_type suffix across the entire blueprint.
Zone Overrides: If a zone is explicitly provided within a specific module, the validator overrides the global zone for that module's validation logic.
Default Validation: The validator has been integrated into the default suite of checks run during blueprint validation.

Warning Handling

A new helper function, handleSoftWarning, has been implemented to manage environment-related API errors.

Non-Blocking Errors: For issues like 403 Forbidden (missing permissions) or 400 Bad Request (disabled APIs), the validator issues a console warning and a troubleshooting hint instead of halting the deployment.
Skipping Logic: In these cases, the check is skipped to avoid blocking users in restricted environments.

Documentation & Testing

Documentation: Updated docs/blueprint-validation.md with comprehensive details on inputs, pass/fail conditions, and manual testing examples.
Testing: Added unit tests in pkg/validators/validators_test.go and updated tools/validate_configs/validate_configs.sh to skip the validator during specific automated configuration tests. This skip is necessary because these tests use a placeholder "invalid-project" ID, which would cause the new validator's live API calls to fail

gemini-code-assist · 2026-01-13T10:18:53Z

Summary of Changes

Hello @saara-tyagi27, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the HPC Toolkit's blueprint validation process by adding a new validator to ensure that all specified Google Cloud machine types are valid and available within their designated zones. This proactive check helps users catch potential configuration errors early, preventing deployment failures and improving the overall reliability of blueprint definitions.

Highlights

New Machine Type Validator: Introduced a new validator, testMachineTypeAvailability, which checks if machine types specified in blueprint modules are available in their respective Google Cloud zones.
API Integration and Error Handling: The validator integrates with the Google Compute Engine API to query machine type availability. It includes robust error handling, treating API permission issues (403) or disabled APIs (400) as warnings to avoid blocking validation unnecessarily.
Blueprint Module Traversal: The validator intelligently traverses blueprint modules, identifies settings related to machine types (e.g., machine_type, _machine_type), resolves their values, and then performs the availability check.
Default Validator Inclusion: The new machine type validator is automatically added to the default set of validators that run during blueprint validation, ensuring comprehensive checks by default.
Golden Copy Test Exclusion: The test_machine_type_in_zone validator has been explicitly added to the skipped validators list in the validate.sh script for golden copy tests, indicating it's not intended to run in that specific testing context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new validator to verify that a specified machine type is available in a given zone. This is a valuable addition for preventing deployment failures due to misconfigurations. The implementation correctly iterates through modules, identifies machine type settings, and validates them against the Compute Engine API. My review includes a couple of suggestions to improve a warning message and enhance code formatting for better readability and maintainability.

pkg/validators/cloud.go

pkg/validators/validators.go

saara-tyagi27 · 2026-01-21T06:02:26Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new and valuable validator, test_machine_type_in_zone, to verify Google Cloud machine type availability before deployment. The implementation is well-executed, with automatic discovery of machine types and graceful handling of environmental issues like API or permission errors through a new soft warning mechanism. The accompanying documentation and test updates are thorough and clear. My review includes one suggestion to improve the design of the new warning handling logic for better testability and separation of concerns, in line with the project's goals for technical excellence and maintainability.

pkg/validators/cloud.go

arpit974 · 2026-01-22T03:51:49Z

docs/blueprint-validation.md

+    inputs:
+      project_id: $(vars.project_id)
+      zone: $(vars.zone)
+      machine_type: c2-standard-60  # any machine type to verify in the zone


hardcoded machines type here..?

As machine_type is not a global variable in most blueprints, I specified a hardcoded one. But if a global variable is defined that can be referenced as well.

saara-tyagi27 · 2026-01-22T18:36:39Z

/gemini review

gemini-code-assist

Code Review

This is a well-executed pull request that introduces a valuable new validator, test_machine_type_in_zone. The implementation is robust, featuring automatic discovery of machine types, intelligent handling of zone overrides, and a thoughtful approach to API errors using soft warnings to avoid blocking deployments unnecessarily. The addition of comprehensive unit tests using a mocked compute service is excellent and ensures the new logic is reliable. The documentation is also clear and thorough. I have one minor suggestion to improve code consistency.

pkg/validators/cloud_discovery.go

Add machine type in zone validator

176c7d9

gemini-code-assist bot reviewed Jan 13, 2026

View reviewed changes

pkg/validators/cloud.go Outdated Show resolved Hide resolved

pkg/validators/validators.go Outdated Show resolved Hide resolved

saara-tyagi27 added 2 commits January 14, 2026 07:09

Address gemini suggestions

fd4e421

add generic function for api warning

c1ce198

saara-tyagi27 marked this pull request as ready for review January 16, 2026 10:09

saara-tyagi27 requested review from a team and samskillman as code owners January 16, 2026 10:09

saara-tyagi27 requested a review from arpit974 January 16, 2026 10:09

saara-tyagi27 added the release-chore To not include into release notes label Jan 16, 2026

saara-tyagi27 added 3 commits January 16, 2026 10:51

update validate_configs file

e70febd

Better logging

1d91b13

Add helper functions and add usage in documentation

1822d22

gemini-code-assist bot reviewed Jan 21, 2026

View reviewed changes

pkg/validators/cloud.go Outdated Show resolved Hide resolved

saara-tyagi27 added 2 commits January 21, 2026 07:50

refactor soft warning

d56cea9

nit

785c92f

arpit974 reviewed Jan 22, 2026

View reviewed changes

saara-tyagi27 added 4 commits January 22, 2026 14:32

Handle zones logic as well

1454b0f

Fix pre-commit error

a5c6e1e

add errors in errors.go

89214c9

Add test cases

8133b8d

gemini-code-assist bot reviewed Jan 22, 2026

View reviewed changes

pkg/validators/cloud_discovery.go Outdated Show resolved Hide resolved

use error const in file

264306e

saara-tyagi27 requested a review from arpit974 January 27, 2026 09:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add machine type in zone validator #5099

Add machine type in zone validator #5099

Uh oh!

saara-tyagi27 commented Jan 13, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Jan 13, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

saara-tyagi27 commented Jan 21, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

arpit974 Jan 22, 2026

Uh oh!

saara-tyagi27 Jan 22, 2026

Uh oh!

saara-tyagi27 commented Jan 22, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add machine type in zone validator #5099

Are you sure you want to change the base?

Add machine type in zone validator #5099

Uh oh!

Conversation

saara-tyagi27 commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Features

Warning Handling

Documentation & Testing

Uh oh!

gemini-code-assist bot commented Jan 13, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

saara-tyagi27 commented Jan 21, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

arpit974 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

saara-tyagi27 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

saara-tyagi27 commented Jan 22, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

saara-tyagi27 commented Jan 13, 2026 •

edited

Loading